refactor(suffix): be consistent with index suffix

demarches-simplifiees · May 7, 2024 · e3f3c6b · e3f3c6b
1 parent 65e5a32
commit e3f3c6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/app/models/export_template.rb b/app/models/export_template.rb
@@ -148,11 +148,8 @@ def attachment_path(dossier, attachment, index, row_index)
   end
 
   def suffix(attachment, index, row_index)
-    suffix = ""
-    if index >= 1 && !row_index.nil?
-      suffix += "-#{index + 1}"
-      suffix += "-#{row_index + 1}" if row_index
-    end
+    suffix = "-#{index + 1}"
+    suffix += "-#{row_index + 1}" if row_index.present?
 
     suffix + attachment.filename.extension_with_delimiter
   end

diff --git a/spec/services/procedure_export_service_spec.rb b/spec/services/procedure_export_service_spec.rb
@@ -544,7 +544,7 @@
               structure = [
                 "#{base_fn}/",
                 "#{base_fn}/dossier-#{dossier.id}/",
-                "#{base_fn}/dossier-#{dossier.id}/piece_justificative-#{dossier.id}.txt",
+                "#{base_fn}/dossier-#{dossier.id}/piece_justificative-#{dossier.id}-1.txt",
                 "#{base_fn}/dossier-#{dossier.id}/export_#{dossier.id}.pdf"
               ]
               expect(files.size).to eq(structure.size)