fix(api.champs_loader): n+1

demarches-simplifiees · Dec 19, 2024 · a26afbe · a26afbe
1 parent 7ed76c0
commit a26afbe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 33 deletions.
diff --git a/app/graphql/loaders/champ.rb b/app/graphql/loaders/champ.rb
diff --git a/app/graphql/types/dossier_type.rb b/app/graphql/types/dossier_type.rb
@@ -162,19 +162,15 @@ def avis(id: nil)
 
     def champs(id: nil)
       if id.present?
-        Loaders::Champ
-          .for(object, private: false)
-          .load(ApplicationRecord.id_from_typed_id(id))
+        object.project_champs_public.filter { _1.stable_id.to_s == ApplicationRecord.id_from_typed_id(id).to_s }
       else
         object.project_champs_public.filter(&:visible?)
       end
     end
 
     def annotations(id: nil)
       if id.present?
-        Loaders::Champ
-          .for(object, private: true)
-          .load(ApplicationRecord.id_from_typed_id(id))
+        object.project_champs_private.filter { _1.stable_id.to_s == ApplicationRecord.id_from_typed_id(id).to_s }
       else
         object.project_champs_private.filter(&:visible?)
       end