chore(champ): update error catching when fetching external data

app/models/champ.rb

@@ -206,9 +206,7 @@ def describedby_id
   end
 
   def log_fetch_external_data_exception(exception)
-    exceptions = self.fetch_external_data_exceptions ||= []
-    exceptions << exception.inspect
-    update_column(:fetch_external_data_exceptions, exceptions)
+    update_column(:fetch_external_data_exceptions, [exception.inspect])
   end
 
   def fetch_external_data?
@@ -219,10 +217,14 @@ def poll_external_data?
     false
   end
 
+  def fetch_external_data_error?
+    fetch_external_data_exceptions.present? && self.external_id.present?
+  end
+
   def fetch_external_data_pending?
     # We don't have a good mechanism right now to know if the last fetch has errored. So, in order
     # to ensure we don't poll to infinity, we stop after 5 minutes no matter what.
-    fetch_external_data? && poll_external_data? && external_id.present? && data.nil? && updated_at > 5.minutes.ago
+    fetch_external_data? && poll_external_data? && external_id.present? && data.nil? && !fetch_external_data_error?
   end
 
   def fetch_external_data
@@ -273,6 +275,7 @@ def cleanup_if_empty
 
   def fetch_external_data_later
     if fetch_external_data? && external_id.present? && data.nil?
+      update_column(:fetch_external_data_exceptions, [])
       ChampFetchExternalDataJob.perform_later(self, external_id)
     end
   end