Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenShortForm to show variable apy and multiplier together #1682

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

DannyDelott
Copy link
Contributor

Closes #1674

Matching the latest design for the Open Short form.

Additionally:

  • fixed the right alignment of the second Primary stats on each open position form
  • Added loading state skeleton to PoolRow to replace "-" character on Variable APY
image

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:21pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:21pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:21pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:21pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:21pm
testnet-v1 ⬜️ Ignored (Inspect) Dec 13, 2024 4:21pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:21pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:21pm

@DannyDelott DannyDelott changed the title Add skeleton to variable rate on pool row Update OpenShortForm to show variable apy and multiplier together Dec 13, 2024
Copy link
Member

@ryangoree ryangoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥

Comment on lines 32 to 33
<div className="daisy-collapse-title mb-3 min-h-0 p-0 font-medium">
<div className="flex items-center gap-4">{heading}</div>
<div className="flex items-center gap-4 hover:text-white">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can probably be merged.

@DannyDelott DannyDelott force-pushed the danny-1674-open-short-layout branch from 5a6c71d to b9574b9 Compare December 13, 2024 16:20
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: b9574b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Open Short form design
2 participants