Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out components for Points Markets page #1680

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

DannyDelott
Copy link
Contributor

@DannyDelott DannyDelott commented Dec 12, 2024

Related to #1681

Adding component layout w/ stubbed data for Pools Markets, based on figma design here: https://www.figma.com/design/zyvr6cjxpcXZlrQJCrBrpy/Hyperdrive-Trading-UI?node-id=1293-3560&node-type=canvas&t=PmFvIpqpgoR96N3u-0

Will re-use the pattern from #1679 to implement sorting and filtering on this page once that lands.

image

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: fdc8828

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:17pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:17pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Dec 12, 2024 11:17pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Dec 12, 2024 11:17pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Dec 12, 2024 11:17pm
testnet-v1 ⬜️ Ignored (Inspect) Dec 12, 2024 11:17pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Dec 12, 2024 11:17pm
trading-competition ⬜️ Ignored (Inspect) Dec 12, 2024 11:17pm

hyperdriveAddress: hyperdrive.address,
appConfig,
});
return !!yieldSource.rewardsFn;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here that we'll need to revisit this in the future. Just because there is a rewards function doesn't mean there will be a claimable action the user can take on it. It's a good starting point to narrow down the hyperdrives.

@DannyDelott DannyDelott merged commit 4e53341 into main Dec 13, 2024
15 checks passed
@DannyDelott DannyDelott deleted the danny-1673-points-markets-page branch December 13, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants