Ensure Falsy values are returned from cache (#81)

* Ensure falsy values are returned from cache * Add changeset
delvtech · Sep 17, 2024 · afa0069 · afa0069
1 parent 765669d
commit afa0069
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/honest-walls-float.md b/.changeset/honest-walls-float.md
@@ -0,0 +1,5 @@
+---
+"@delvtech/evm-client": patch
+---
+
+Ensure Falsy values don't result in cache misses.
diff --git a/packages/evm-client/src/contract/factories/createCachedReadContract.ts b/packages/evm-client/src/contract/factories/createCachedReadContract.ts
@@ -157,7 +157,7 @@ async function getOrSet<TValue>({
   callback: () => Promise<TValue> | TValue;
 }): Promise<TValue> {
   let value = cache.get(key);
-  if (value) {
+  if (typeof value !== 'undefined') {
     return value;
   }