Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GSC button and toasts #431

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Fix GSC button and toasts #431

merged 11 commits into from
Jun 25, 2024

Conversation

ryangoree
Copy link
Member

@ryangoree ryangoree commented Jun 25, 2024 •
edited
Loading

Primary patches:

  • Ensures the GSC button is shown for eligible members.
  • Fixes transactions toasts.

The commits tell the rest of the story.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 4ab02bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
council-kit-council-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:46pm
council-kit-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:46pm

jrhea
jrhea approved these changes Jun 25, 2024
View reviewed changes
Copy link

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryangoree ryangoree merged commit 6272879 into main Jun 25, 2024
8 checks passed
@ryangoree ryangoree deleted the ryan-patches branch June 25, 2024 15:07
ryangoree added a commit to element-foundation/council-kit that referenced this pull request Jun 25, 2024
@ryangoree
Fix GSC button and toasts (delvtech#431)
81f1eb5 
* Show join button on GSC Vault page

* Update council artifacts to `5f7be33`

* Make wallet connect optional

* Add locking-vault get-voting-power command

* Add locking-vault withdraw command

* Update evm-client

* Bump all viem versions

* Fix transaction toasts

* Open etherscan links in new tabs

* Fix gsc vault deployment in default command

* Fix join GSC button
ryangoree added a commit to element-foundation/council-kit that referenced this pull request Jun 25, 2024
@ryangoree
Fix GSC button and toasts (delvtech#431) (#22)
3cd855c 
* Show join button on GSC Vault page

* Update council artifacts to `5f7be33`

* Make wallet connect optional

* Add locking-vault get-voting-power command

* Add locking-vault withdraw command

* Update evm-client

* Bump all viem versions

* Fix transaction toasts

* Open etherscan links in new tabs

* Fix gsc vault deployment in default command

* Fix join GSC button
@ryangoree ryangoree mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhea jrhea jrhea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryangoree @jrhea