Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra data to trade events in db #1720

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

slundqui
Copy link
Contributor

No description provided.

@slundqui slundqui enabled auto-merge (squash) October 30, 2024 18:05
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (3f3bf02) to head (f2ec456).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gent0/ethpy/hyperdrive/interface/read_interface.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
- Coverage   81.29%   81.12%   -0.17%     
==========================================
  Files          93       93              
  Lines        7013     7016       +3     
==========================================
- Hits         5701     5692       -9     
- Misses       1312     1324      +12     
Flag Coverage Δ
unittests 81.12% <71.42%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit ba7aa56 into delvtech:main Oct 30, 2024
4 of 5 checks passed
@slundqui slundqui deleted the extra-data-db branch October 30, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants