refactor: move tree in own crate

[jns-ps]

Summary by CodeRabbit

• New Features

  • Introduced a new prism-tree package with enhanced tree structure functionalities.
  • Added a comprehensive suite of unit tests for the KeyDirectoryTree functionality.

• Bug Fixes

  • Updated hashing mechanisms across various modules to improve consistency and type safety.

• Documentation

  • Enhanced documentation regarding the new HashchainResponse enumeration for better clarity in handling hashchain queries.

• Chores

  • Updated import statements across several files to reflect the new module organization and dependencies.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a comprehensive refactoring of the project's tree-related functionality by creating a new prism-tree crate. The changes involve renaming the Hasher to TreeHasher, updating import statements across multiple modules, and reorganizing the implementation of tree-related structures and proofs. The modifications primarily focus on improving the modularity and clarity of the tree and hashing implementations while maintaining the existing core functionality.

Changes

File	Change Summary
Cargo.toml	Added crates/tree to workspace members and dependencies
crates/common/Cargo.toml	Removed prism-errors and log dependencies, updated jmt to sha2
crates/common/src/digest.rs	Replaced Hasher with Sha256, removed RootHash conversion implementations
crates/common/src/lib.rs	Removed hasher and tree module declarations
crates/node_types/prover/Cargo.toml	Added prism-tree dependency
crates/node_types/prover/src/webserver.rs	Updated proof handling to use TreeHasher
crates/tree/Cargo.toml	New package configuration with dependencies
crates/tree/src/hasher.rs	Renamed Hasher to TreeHasher, updated implementations
crates/tree/src/key_directory_tree.rs	Updated to use TreeHasher
crates/tree/src/lib.rs	Added new modules and HashchainResponse enum
crates/tree/src/proofs.rs	Updated proof structures to use TreeHasher
crates/tree/src/snarkable_tree.rs	Updated method signatures and type handling
crates/zk/sp1/Cargo.toml	Added prism-tree dependency
crates/zk/sp1/src/main.rs	Updated imports and Digest handling

Possibly related issues

• refactor: SnarkableTree #183: Refactoring the SnarkableTree trait, which aligns with the current PR's focus on restructuring tree-related functionality.

Possibly related PRs

• refactor: refactoring into crates and adding nova, sp1 #115: Workspace configuration restructuring
• feat(sp1): Integrating SP1 program into prism-main #119: SP1 program integration
• feature(prover): hex formatting for proofs in REST API #166: Webserver proof handling modifications
• fix: avoid double hashing JMT keys #170: JMT key hashing improvements

Suggested reviewers

• sebasti810

Poem

🌳 In the forest of code, a tree takes flight
Hasher renamed, dependencies tight
Refactoring branches with elegant grace
A new crate emerges, finding its place
Rust whispers secrets of modularity's might! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 987b01c and 46e2e12.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (18)

• Cargo.toml (3 hunks)
• crates/common/Cargo.toml (1 hunks)
• crates/common/src/digest.rs (2 hunks)
• crates/common/src/lib.rs (0 hunks)
• crates/common/src/tree/mod.rs (0 hunks)
• crates/node_types/prover/Cargo.toml (1 hunks)
• crates/node_types/prover/src/prover/mod.rs (2 hunks)
• crates/node_types/prover/src/prover/tests.rs (1 hunks)
• crates/node_types/prover/src/webserver.rs (2 hunks)
• crates/tree/Cargo.toml (1 hunks)
• crates/tree/src/hasher.rs (3 hunks)
• crates/tree/src/key_directory_tree.rs (3 hunks)
• crates/tree/src/lib.rs (1 hunks)
• crates/tree/src/proofs.rs (7 hunks)
• crates/tree/src/snarkable_tree.rs (9 hunks)
• crates/tree/src/tests.rs (1 hunks)
• crates/zk/sp1/Cargo.toml (1 hunks)
• crates/zk/sp1/src/main.rs (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.