Don't always show the sender in notifications #3441
Merged
+16
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the changes in this pull request, install this apk: |
adbenitez
reviewed
Nov 23, 2024
| DcContact contact = dcContext.getContact(dcMsg.getFromId()); | ||
| tickerLine = dcMsg.getSenderName(contact, false) + ": " + tickerLine; | ||
|
|
||
| if (!Util.equals(dcChat.getName(), contact.getDisplayName())) { |
There was a problem hiding this comment.
this sounds hacky (ex. if someone sets name == group name), I would directly check:
IF dcChat is multi-user OR dcMsg has overriden sender name THEN show it ELSE don't show it
|
To test the changes in this pull request, install this apk: |
When we introduced this, I assume that we weren't sure whether we should do it and only showed it in some places. But I think it's nicer to show the same sender name everywhere, i.e. always add the "~".
Hocuri
force-pushed
the
hoc/dont-always-show-sender-in-notifications
branch
from
4c4ec1a
to
0cf4ed1
Compare
adbenitez
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1:1 chats, don't prepend the sender name to every line. The exception is when the display name is not equal to the chat name (i.e. there is an OverwriteSenderDisplayname), in this case we still prepend it.
This is how it looks when Bob2 sends 4 messages, and then I get 1 message from Hocuri4 that is assigned to the same chat: