Add blkptr command to sdb #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsurya
approved these changes
Mar 17, 2023
grwilson
force-pushed
the
blkptr
branch
3 times, most recently
from
18b0c6e to
5ab8937
Compare
ahrens
reviewed
Mar 21, 2023
|
@grwilson I'm still in the middle of writing the Dev Resources for how to generate the test output so I just quickly generated it for you in this commit: In the above commit I also fixed a bug where you don't have the Finally can you please rebase your PR over the latest 6.0/stage branch? |
ahrens
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= Problem
This leverages the original work by @PaulZ-98 from PR #281. This add the
blkptrcommand to sdb .= Solution
I tried to structure the code so that it is similar to the C code so that it's easier to enhance in the future. All of the
BP_*macros that are used by ZFS were also added to make future enhancements easier.