Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on io/ioutil, update Go to 1.21 #54

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

donatwork
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#916

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@donatwork
Copy link
Contributor Author

e2e pass

Copy link

@anandrajak1 anandrajak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e pass

@donatwork donatwork closed this Aug 23, 2023
@donatwork donatwork reopened this Aug 23, 2023
@donatwork donatwork closed this Aug 23, 2023
@donatwork donatwork reopened this Aug 23, 2023
@donatwork
Copy link
Contributor Author

e2e pass

@donatwork donatwork merged commit fac0ec2 into main Aug 23, 2023
12 of 15 checks passed
@donatwork donatwork deleted the 916-ioutil-removal branch August 23, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants