-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering get topology count for specific sc key #98
Open
sakshi-garg1
wants to merge
85
commits into
main
Choose a base branch
from
multi-driver-capacity-tracking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshi-garg1
requested review from
adarsh-dell,
AkshaySainiDell,
bharathsreekanth,
harishp8889,
JacobGros,
Prabhu-Dell,
rajkumar-palani,
khareRajshree,
shefali-malhotra,
panigs7,
tssushma,
gilltaran,
shanmydell,
alikdell,
atye,
coulof,
shaynafinocchiaro,
xuluna and
EvgenyUglov
as code owners
November 14, 2024 11:07
…ell/cert-csi into multi-driver-capacity-tracking
…go coverage increased from 66.7% to 69.2%
…verage increased from 69.2% to 70.3%
…ell/cert-csi into multi-driver-capacity-tracking
…overage increased from 70.3% to 71.4%
…ell/cert-csi into multi-driver-capacity-tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customer was facing issue with running cert-csi functional test when they had multiple drivers installed. The issue with the test was that it was getting all the topologies for all drivers.
To resolve this, we will only get topology keys based on the ones listed in the storage class.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration