Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to bind UA instead of only IP in challenge/password cookie #43

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

jeremy5189
Copy link
Contributor

No description provided.

@jeremy5189 jeremy5189 changed the title Add getShaInvBinding and apply Option to bind UA instead of only IP in challenge/password cookie Sep 25, 2023
@jeremy5189 jeremy5189 force-pushed the feature/challenger-user-agent branch from 5c53bbe to 7fc55e3 Compare September 27, 2023 07:48
@mhqz
Copy link
Contributor

mhqz commented Sep 27, 2023

Hi @jeremy5189, the code looks fine to me.

A possible improvement would be to rename getUserAgentOrIp() that would let us to use the same method for different IDs (IP, User Agent, Private User Token, etc), e.g. getClientID() or getClientIdentifier().

@jeremy5189
Copy link
Contributor Author

@mhqz Sounds like a good idea, but currently our session id is only valid for 1hr, to do this I guess we must make it same as the TTL of challenge / password cookie?

@mhqz
Copy link
Contributor

mhqz commented Sep 28, 2023

@mhqz Sounds like a good idea, but currently our session id is only valid for 1hr,

Oh, I see.

to do this I guess we must make it same as the TTL of challenge / password cookie?

Yeah, that's an option, but if it's too much trouble we could just leave it as it is, no problem.

@jeremy5189 jeremy5189 force-pushed the feature/challenger-user-agent branch from 6461114 to 639167e Compare October 17, 2023 14:18
@jeremy5189 jeremy5189 merged commit 4fbbbad into main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants