Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(assessment): adjust reason accordingly across multiple components #862

Merged
merged 6 commits into from
Dec 20, 2024
Merged

fix(assessment): adjust reason accordingly across multiple components #862

merged 6 commits into from
Dec 20, 2024

Conversation

brandtkeller
Copy link
Member

Description

Minor gap found when testing across multiple components with the same control-id implemented-requirement.

Related Issue

Fixes #861

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@brandtkeller brandtkeller self-assigned this Dec 19, 2024
@brandtkeller brandtkeller requested a review from a team as a code owner December 19, 2024 23:30
CloudBeard
CloudBeard approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@CloudBeard CloudBeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, this should make it easier to find things in the assessment results manually and setup for report/console/etc later on too.

@brandtkeller brandtkeller merged commit f0fe67c into main Dec 20, 2024
10 checks passed
@brandtkeller brandtkeller deleted the 861-finding-reason branch December 20, 2024 19:59
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
@meganwolf0 meganwolf0 mentioned this pull request Jan 6, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudBeard CloudBeard CloudBeard approved these changes

Assignees

@brandtkeller brandtkeller

Labels
None yet
Projects
Lula and Friends
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve clarity around newly implemented "reason"
2 participants
@brandtkeller @CloudBeard