Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oscal): update version of assessment results generated #853

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

brandtkeller
Copy link
Member

Description

Noticed the assessment-results object output from validate was not version 1.1.3 due to a constant we have defined. Bumping this version to match intended version.

Related Issue

No issue - noticed a part of the workflow missing update from the transition to OSCAL 1.1.3 artifacts.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@brandtkeller brandtkeller requested a review from a team as a code owner December 12, 2024 21:41
@brandtkeller brandtkeller self-assigned this Dec 12, 2024
@brandtkeller brandtkeller added this to the v0.14.0 milestone Dec 12, 2024
Copy link
Collaborator

@meganwolf0 meganwolf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a latestVersion const in go-oscal - wonder if it might make sense to make that public instead and use that in the future?

@brandtkeller
Copy link
Member Author

I see a latestVersion const in go-oscal - wonder if it might make sense to make that public instead and use that in the future?

Worth consideration - It would remove potential drift when updating - but also remove some inherent control that a consumer of the library has over updating the dependency with additional plan to work through some supporting behaviors before consuming the type updates.

@brandtkeller brandtkeller merged commit 0774f66 into main Dec 13, 2024
10 checks passed
@brandtkeller brandtkeller deleted the hotfix_assessment_oscalver branch December 13, 2024 16:11
mildwonkey pushed a commit that referenced this pull request Dec 16, 2024
* fix(oscal): update version of assessment results generated

* fix(test): update golden file

---------

Co-authored-by: Megan Wolf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants