-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validation-tests): validation tests path resolution #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo to fix, the other suggestions you are free to take or ignore as you see fit! This looks good, and I like your documentation.
Co-authored-by: Kristin Laemmert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
(I'll re-approve if you want to change the integer map key wording but my actual requested changes are resolved)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes! 😀 ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the test-a-validation.md
doc.
Description
Updates the validation testing and fixes a bug with the way indicies were identified (see #840 ) for specific bug.
This PR includes
key[foo=bar]
is equivalent tokey.[foo=bar]
Related Issue
Fixes #840
Type of change
Checklist before merging