Maturin #1336
Merged
Maturin #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WardDeb would it make sense to split up this PR in many small ones? Maybe even per tool? I guess this makes it easier to review them. |
Not so sure to split them up atm (note that for this PR only bamCoverage is properly implemented, only babysteps for bamCompare, so this PR corresponds to one tool..). The number of files changed looks daunting as all the python code got moved into pydeeptools folder, but actually not that much changed. I'll go ahead and merge this, but keep maturin separated for now. We can discuss moving up to develop next wednesday :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for deepTools 4 overhaul.