Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Tool to a separate package; refactor serde #8690

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 9, 2025

Related Issues

Since we plan to introduce some subclasses of Tool (ComponentTool etc.), we thought of moving the dataclass into a dedicated package and make serialization/deserialization more flexible.

Proposed Changes:

How did you test it?

CI, adapted tests

Notes for the reviewer

@dfokina your input here is necessary for the API reference docs.

  • I removed the tool module from data_classes_api.
  • I renamed tools_api (which previously contained components related to Tools, such as ToolInvoker) to tools_components_api.
  • I put the new module tool (from tools package) into tools_api.

LMK if this makes sense.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 self-assigned this Jan 9, 2025
@anakin87 anakin87 marked this pull request as ready for review January 9, 2025 09:41
@anakin87 anakin87 requested review from a team as code owners January 9, 2025 09:41
@anakin87 anakin87 requested review from dfokina, davidsbatista and vblagoje and removed request for a team and davidsbatista January 9, 2025 09:41
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @anakin87

Copy link
Contributor

@dfokina dfokina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it works well, thanks @anakin87 !

@anakin87 anakin87 merged commit 3f15f38 into main Jan 9, 2025
19 checks passed
@anakin87 anakin87 deleted the tool-refactor branch January 9, 2025 11:30
@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2025

Pull Request Test Coverage Report for Build 12687357337

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 91.094%

Totals Coverage Status
Change from base Build 12685847396: 0.006%
Covered Lines: 8653
Relevant Lines: 9499

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants