refactor: move Tool
to a separate package; refactor serde
#8690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Since we plan to introduce some subclasses of
Tool
(ComponentTool
etc.), we thought of moving the dataclass into a dedicated package and make serialization/deserialization more flexible.Proposed Changes:
Tool
to a new dedicatedtools
package.Tool
serialization and deserialization to make it more flexible and include type information. (Same approach as POC in Tool from Component YAML serde POC haystack-experimental#164)How did you test it?
CI, adapted tests
Notes for the reviewer
@dfokina your input here is necessary for the API reference docs.
tool
module fromdata_classes_api
.tools_api
(which previously contained components related to Tools, such asToolInvoker
) totools_components_api
.tool
(fromtools
package) intotools_api
.LMK if this makes sense.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.