Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update links to ChatMessage docs #8667

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: update links to ChatMessage docs #8667

merged 1 commit into from
Dec 20, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Dec 20, 2024 •
edited
Loading

Related Issues

Starting from 2.9.0, the ChatMessage dataclass will be documented in a specific page.
See #8623 (comment)

Proposed Changes:

  • update all links to ChatMessage docs: it's particularly relevant because we are publishing the migration guide in the docs.

Notes for the reviewer

This URL does not exist now and will be created with the 2.9.0 release.
Currently docs can be found at https://docs.haystack.deepset.ai/v2.9-unstable/docs/chatmessage

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added the type:documentation Improvements on the docs label Dec 20, 2024
@anakin87 anakin87 added this to the 2.9.0 milestone Dec 20, 2024
@anakin87 anakin87 marked this pull request as ready for review December 20, 2024 14:01
@anakin87 anakin87 requested review from a team as code owners December 20, 2024 14:01
@anakin87 anakin87 requested review from dfokina and davidsbatista and removed request for a team December 20, 2024 14:01
@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12432726178

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.715%
Totals Coverage Status
Change from base Build 12431916013: 0.0%
Covered Lines: 8451
Relevant Lines: 9316
💛 - Coveralls

@davidsbatista davidsbatista removed the type:documentation Improvements on the docs label Dec 20, 2024
@anakin87 anakin87 merged commit 99e7e34 into main Dec 20, 2024
36 checks passed
@anakin87 anakin87 deleted the update-chatmessage-link-to-docs branch December 20, 2024 14:33
@davidsbatista davidsbatista added the type:documentation Improvements on the docs label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfokina dfokina dfokina approved these changes

@davidsbatista davidsbatista Awaiting requested review from davidsbatista davidsbatista is a code owner automatically assigned from deepset-ai/open-source-engineering

@vblagoje vblagoje Awaiting requested review from vblagoje

Assignees
No one assigned
Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anakin87 @coveralls @dfokina @davidsbatista