Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding missing abbreviations files for SentenceSplitter #8660

Merged
merged 2 commits into from
Dec 19, 2024
+2,075 −2
Merged

fix: adding missing abbreviations files for SentenceSplitter #8660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19f1011
adding missing abbreviations files for SentenceSplitter
davidsbatista Dec 19, 2024
8c2ddab
fixing tests path
davidsbatista Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ repos:
rev: v2.3.0
hooks:
- id: codespell
exclude: "haystack/data/abbreviations"
args: ["--toml", "pyproject.toml"]
additional_dependencies:
- tomli
Expand Down
2 changes: 1 addition & 1 deletion haystack/components/preprocessors/sentence_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def _read_abbreviations(lang: Language) -> List[str]:
:param lang: The language to read the abbreviations for.
:returns: List of abbreviations.
"""
abbreviations_file = Path(__file__).parent.parent / f"data/abbreviations/{lang}.txt"
abbreviations_file = Path(__file__).parent.parent.parent / f"data/abbreviations/{lang}.txt"
if not abbreviations_file.exists():
logger.warning("No abbreviations file found for {language}. Using default abbreviations.", language=lang)
return []
Expand Down
Loading
Loading