-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: new ChatMessage
#8640
Merged
Merged
feat!: new ChatMessage
#8640
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4b941b0
draft
anakin87 9ec7de7
del HF token in tests
anakin87 4865ab0
Merge branch 'fix-hf-token-test' into new-chatmessage
anakin87 7b6e9d2
adaptations
anakin87 c462ddc
progress
anakin87 94a103a
Merge branch 'main' into new-chatmessage
anakin87 873ae4f
fix type
anakin87 fe6c4c8
import sorting
anakin87 1a5b46c
more control on deserialization
anakin87 e3f4c89
release note
anakin87 2370c2f
Merge branch 'main' into new-chatmessage
anakin87 180d0f3
improvements
anakin87 328cebd
support name field
anakin87 b88daae
fix chatpromptbuilder test
anakin87 c663d44
Update chat_message.py
dfokina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,16 +13,11 @@ def _convert_message_to_openai_format(message: ChatMessage) -> Dict[str, str]: | |
|
||
See the [API reference](https://platform.openai.com/docs/api-reference/chat/create) for details. | ||
|
||
:returns: A dictionary with the following key: | ||
:returns: A dictionary with the following keys: | ||
- `role` | ||
- `content` | ||
- `name` (optional) | ||
""" | ||
if message.text is None: | ||
raise ValueError(f"The provided ChatMessage has no text. ChatMessage: {message}") | ||
|
||
openai_msg = {"role": message.role.value, "content": message.text} | ||
if message.name: | ||
openai_msg["name"] = message.name | ||
|
||
return openai_msg | ||
return {"role": message.role.value, "content": message.text} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these changes to the OpenAI Chat Generator are only temporary: we will override them soon when porting the support for Tools |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes to HF API Chat Generator are only temporary: we will override them soon when porting the support for Tools