Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update components to access ChatMessage.text instead of content #8589

Merged
merged 6 commits into from
Nov 28, 2024
Merged

refactor: update components to access ChatMessage.text instead of content #8589

merged 6 commits into from
Nov 28, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 27, 2024 •
edited
Loading

Related Issues

Proposed Changes:

Update components to access ChatMessage.text instead of content

How did you test it?

CI

Notes for the reviewer

  • this PR is based on the branch of refactor: ChatMessage - introduce text property and deprecate content #8588
  • I added new conditions to check that text (Optional[str]) is not None: currently text mirrrors content (str), so this cannot happen; text will allow null values in 2.9.0
  • I left unchanged the Chat Generator for which we added experimental tools support (OpenAI and Hugging Face): these will be completely replaced in 2.9.0

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Nov 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12066639057

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.05%) to 90.307%
Files with Coverage Reduction New Missed Lines %
components/generators/openai_utils.py 1 88.89%
components/builders/answer_builder.py 2 96.83%
components/builders/chat_prompt_builder.py 3 95.89%
components/connectors/openapi_service.py 4 95.0%
components/validators/json_schema.py 5 89.19%
Totals Coverage Status
Change from base Build 12066481396: -0.05%
Covered Lines: 8031
Relevant Lines: 8893
💛 - Coveralls

@anakin87 anakin87 changed the base branch from main to chatmessage-text November 27, 2024 15:32
@anakin87 anakin87 changed the title Use chatmessage text refactor: update components to access ChatMessage.text instead of content Nov 27, 2024
@anakin87 anakin87 marked this pull request as ready for review November 27, 2024 16:09
@anakin87 anakin87 requested review from a team as code owners November 27, 2024 16:09
@anakin87 anakin87 requested review from dfokina and mpangrazzi and removed request for a team November 27, 2024 16:09
@anakin87 anakin87 added this to the 2.8.0 milestone Nov 27, 2024
Base automatically changed from chatmessage-text to main November 28, 2024 09:53
@anakin87 anakin87 enabled auto-merge (squash) November 28, 2024 10:06
@anakin87 anakin87 merged commit c8685aa into main Nov 28, 2024
18 checks passed
@anakin87 anakin87 deleted the use-chatmessage-text branch November 28, 2024 10:16
@anakin87 anakin87 mentioned this pull request Nov 28, 2024
Closed
Amnah199 pushed a commit that referenced this pull request Dec 3, 2024
@anakin87 @Amnah199
refactor: update components to access ChatMessage.text instead of `…
7d7bf6f 
…content` (#8589)

* introduce text property and deprecate content

* release note

* use chatmessage.text

* release note

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpangrazzi mpangrazzi mpangrazzi approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @mpangrazzi