feat: Deprecate max_loops_allowed
in favour of new argument max_runs_per_component
#8354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Pipeline.__init__()
argumentmax_loops_allowed
as it is misleading #8291Proposed Changes:
This PR deprecates the existing
Pipeline
init argumentmax_loops_allowed
in favor of the newly addedmax_runs_per_component
.This doesn't change any internal behaviour as
max_loops_allowed
was actually used to verify the number of runs per Component.To reflect the name change of the init argument I also deprecated the
PipelineMaxLoops
exception in favor of the newPipelineMaxComponentRuns
.Pipeline.to_dict()
doesn't savemax_loops_allowed
anymore but justmax_runs_per_component
.Pipeline.from_dict()
instead still supportsmax_loops_allowed
if found.How did you test it?
I added new tests and fixed the broken ones.
Notes for the reviewer
N/A
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.