Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fetch_archive_from_http to fetch zip or gzip archives #7806

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jun 5, 2024

Related Issues

Proposed Changes:

Add fetch_archive_from_http to fetch zip or gzip archives.
This function has been previously removed for security reasons as it also supported tar files unpacking via tarfile module.
This version drops support for tar files so it's safe to use.

How did you test it?

I didn't ran any test, this function wasn't tested previously.

Notes for the reviewer

I'll make a new release after this is merged.

Checklist

@silvanocerza silvanocerza requested a review from shadeMe June 5, 2024 12:59
@silvanocerza silvanocerza requested review from a team as code owners June 5, 2024 12:59
@silvanocerza silvanocerza requested review from dfokina and davidsbatista and removed request for a team and davidsbatista June 5, 2024 12:59
@github-actions github-actions bot added the type:documentation Improvements on the docs label Jun 5, 2024
@silvanocerza silvanocerza changed the base branch from v1.x to v1.26.x June 5, 2024 13:05
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small improvement otherwise, look good to me

haystack/utils/import_utils.py Show resolved Hide resolved
@silvanocerza silvanocerza merged commit acecc40 into v1.26.x Jun 5, 2024
56 checks passed
@silvanocerza silvanocerza deleted the safe-fetch branch June 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants