-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Retire openapi3, use openapi-service-client instead #7514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
topic:build/distribution
2.x
Related to Haystack v2.0
type:documentation
Improvements on the docs
labels
Apr 9, 2024
Pull Request Test Coverage Report for Build 9206625458Details
💛 - Coveralls |
vblagoje
force-pushed
the
integrate_openapi_service_client
branch
from
April 9, 2024 13:45
aabe2d7
to
b109d3c
Compare
vblagoje
force-pushed
the
integrate_openapi_service_client
branch
from
April 16, 2024 13:49
b109d3c
to
c0a9024
Compare
vblagoje
force-pushed
the
integrate_openapi_service_client
branch
4 times, most recently
from
May 2, 2024 09:39
b959918
to
56a1440
Compare
vblagoje
force-pushed
the
integrate_openapi_service_client
branch
from
May 7, 2024 08:18
8f19fcd
to
e0ae77e
Compare
vblagoje
requested review from
dfokina,
anakin87 and
masci
and removed request for
a team
May 7, 2024 14:34
vblagoje
force-pushed
the
integrate_openapi_service_client
branch
from
May 23, 2024 10:45
977d3e4
to
decf03a
Compare
Superseded by deepset-ai/haystack-experimental#8 - closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.x
Related to Haystack v2.0
topic:build/distribution
topic:tests
type:documentation
Improvements on the docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The pull request eviscerates the underlying openapi3 library used under the hood in
OpenAPIServiceConnector
and replaces it with out own openapi library. The main motivations for replacement of the old library are:These bugs were related to their mechanism of checking for responses being valid as defined by schema. In theory that works great but one could not make this validation step optional and they had a few bugs in there + developers sometimes make tiny mistakes defining schemas in OpenAPI specs. Validation doesn't matter at all for LLMs and we can add this request/response validation later or not at all. A third party lib like pydanticv2 can do the validation of both.
What:
OpenAPI
library usage withopenapi-service-client
library abstractions.OpenAPIServiceToFunctions
OpenAPI schema -> LLM tools translation with use ofget_tools_definitions
invocationopenapi-service-client
library)openapi-service-client
library and the tests testing openapi integration in previous versions of these components do need to be duplicatedHow can it be used:
to:
How did you test it:
OpenAPIServiceClient
instead ofOpenAPI
. The mocking and assertions were adapted to the new implementation.Notes for the reviewer:
openapi3
is replaced withopenapi-service-client
to ensure that all of the intended functionality is preserved.