Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing some docstrings #7465

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fixing some docstrings #7465

merged 1 commit into from
Apr 4, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista requested a review from a team as a code owner April 4, 2024 10:26
@davidsbatista davidsbatista requested review from vblagoje and removed request for a team April 4, 2024 10:26
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Apr 4, 2024
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 4, 2024
@vblagoje
Copy link
Member

vblagoje commented Apr 4, 2024

Wait, was this produced by a tool? cc @davidsbatista

@davidsbatista
Copy link
Contributor Author

by 2 tools :)

  • my fingers
  • a keyboard

I suppose some issues could be fixed with ruff -fix but I haven't explored it enough

@davidsbatista davidsbatista merged commit bf8453e into main Apr 4, 2024
20 of 21 checks passed
@davidsbatista davidsbatista deleted the fixing-some-docstrings branch April 4, 2024 14:54
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8553134419

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.331%
Files with Coverage Reduction New Missed Lines %
utils/device.py 21 89.9%
Totals Coverage Status
Change from base Build 8551366133: 0.0%
Covered Lines: 5618
Relevant Lines: 6289
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @vblagoje @coveralls