fix: page_number for pdfs with pages not containing any text #7271
Conversation
|
(Sorry to intrude...) @vblagoje - release manager |
|
@anakin87 sure thing |
|
Where is the github feature to copy the PR and change the target branch when a man needs it? |
|
If you want to change the target branch, you click "edit" in the top right of this page. |
|
I know that part but I want copy the PR and change the target branch, do they have that? |
There was a problem hiding this comment.
Change looks good to me, although I would have appreciated some minimal test. 👍
Before merging please sync with the release manager @vblagoje
Our usual approach is to merge into the v1.x branch and then the release manager cherry picks into the v1.25.x release branch.
I'll add a test in a few minutes. |
|
@vblagoje I changed the target branch to |
* update version * ci: fix rest-api tests (#7256) * fix: page_number for pdfs with pages not containing any text * Revert "fix: page_number for pdfs with pages not containing any text" This reverts commit ae20bae. * Reapply "fix: page_number for pdfs with pages not containing any text" This reverts commit 18fd55b. * add test --------- Co-authored-by: Vladimir Blagojevic <[email protected]> Co-authored-by: Tobias Wochinger <[email protected]>
Related Issues
Proposed Changes:
pagemeta field for pdfs that contain pages without any text contentHow did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.