feat: Use forward reference for AnalyzeResult #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vblagoje
requested review from
masci and
ZanSara
and removed request for
a team and
masci
vblagoje
added
the
ignore-for-release-notes
|
@masci assigning to Sara as she has the offline context already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The static method
_convert_azure_result_to_documentin theAzureOCRDocumentConverterclass was causing aNameErrordue to the direct use ofAnalyzeResultfrom theazure.ai.formrecognizerpackage, which is an optional dependency. This PR addresses this issue to ensure smooth functionality even when the optional package isn't installed.AnalyzeResultType Error in `AzureOCRDocumentConverter #6028What
The fix involves using a forward reference for
AnalyzeResultin the method signature of_convert_azure_result_to_document.How Can It Be Used
After this fix, users won't get the
NameErroras before. If they do have the package and want to utilize the full functionality, they can do so without any errors.How Did You Test It
azure.ai.formrecognizerpackage installed to ensure noNameErroris thrown.azure.ai.formrecognizerpackage and tested the full functionality of theAzureOCRDocumentConverterclass to ensure it works as expected.