-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow list of file paths in convert_files_to_docs
#5961
feat: allow list of file paths in convert_files_to_docs
#5961
Conversation
Thanks for this @DanShatford , @dfokina please have a quick look. As far as I can tell all looks good. Let's see what CI says |
Pull Request Test Coverage Report for Build 6423867599
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for @dfokina to give it 👍, and we are gtg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side too 👍 @vblagoje
Hi @DanShatford, thank you for your contribution to Haystack! You have a chance to receive an exclusive swag package from Haystack. 🎁 Fill in this form and let us know if you have any questions! https://forms.gle/226vqWoN6NRAaqJ69 |
Related Issues
convert_files_to_docs
for a list of filepaths notdir_path
#5616Proposed Changes:
file paths
toconvert_files_to_docs
instead of, or as well as, the currentdir_path
.How did you test it?
Unit tests. Manual tests.
Notes for the reviewer
file_paths
isList[Path]
whiledir_path
isstr
. This is what was suggested in the issue discussion. I can make the types more consistent if that is preferred, ie, by making both keyword arguments accept (List
)str
/Path
.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.