Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move websearch tests back to main tests suite #5842

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Sep 20, 2023

Related Issues

  • fixes n/a

Proposed Changes:

  • move websearch tests back to main tests suite with the integration marker. They are skipped if the API key is missing.

How did you test it?

n/a

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested a review from a team as a code owner September 20, 2023 09:12
@ZanSara ZanSara requested review from masci and removed request for a team September 20, 2023 09:12
@ZanSara ZanSara requested review from vblagoje and removed request for masci September 20, 2023 09:13
@ZanSara ZanSara added 2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Sep 20, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6246486092

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.251%

Totals Coverage Status
Change from base Build 6246380218: 0.0%
Covered Lines: 11903
Relevant Lines: 24168

💛 - Coveralls

@ZanSara ZanSara merged commit 44f0c46 into main Sep 20, 2023
@ZanSara ZanSara deleted the move-websearch-tests branch September 20, 2023 09:55
@ZanSara ZanSara removed the 2.x Related to Haystack v2.0 label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants