Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate out preview tests #5639

Merged
merged 24 commits into from
Sep 29, 2023
Merged

feat: separate out preview tests #5639

merged 24 commits into from
Sep 29, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Aug 28, 2023

Related Issues

  • fixes n/a

Proposed Changes:

  • Run preview tests only on PRs that affect the haystack/preview and tests/preview directories
  • Same separation applies for the e2e folder

How did you test it?

n/a

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara marked this pull request as ready for review August 29, 2023 14:23
@ZanSara ZanSara requested a review from a team as a code owner August 29, 2023 14:23
@ZanSara ZanSara requested review from bogdankostic and silvanocerza and removed request for a team and bogdankostic August 29, 2023 14:23
@ZanSara ZanSara self-assigned this Aug 29, 2023
@ZanSara ZanSara added this to the 2.0 blockers milestone Sep 25, 2023
@ZanSara
Copy link
Contributor Author

ZanSara commented Sep 28, 2023

With @masci we agreed to temporarily stop tracking coverage with Coveralls for the preview components, so I'm updating this PR to match. We will later restart tracking coverage after the beta release.

@ZanSara ZanSara requested a review from masci September 28, 2023 12:05
@ZanSara ZanSara added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 28, 2023
@github-actions github-actions bot added the type:documentation Improvements on the docs label Sep 28, 2023
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but LGTM

.github/workflows/tests_preview.yml Outdated Show resolved Hide resolved
@ZanSara ZanSara requested a review from masci September 28, 2023 16:20
@ZanSara ZanSara added the 2.x Related to Haystack v2.0 label Sep 28, 2023
masci
masci previously approved these changes Sep 29, 2023
@masci masci dismissed their stale review September 29, 2023 07:22

tests are failing

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tika tests are failing on Windows and starting Tika on Linux gets stuck.

@ZanSara ZanSara merged commit 81b2e83 into main Sep 29, 2023
@ZanSara ZanSara deleted the separate-test-workflow-for-2.0 branch September 29, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants