Skip to content

Commit

Permalink
feat: Unfreeze Document in Haystack 2.0 (#5974)
Browse files Browse the repository at this point in the history
* Unfreeze document

* Remove immutability test
  • Loading branch information
vblagoje authored Oct 5, 2023
1 parent f983e60 commit 282419d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 18 deletions.
10 changes: 4 additions & 6 deletions haystack/preview/dataclasses/document.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
from typing import List, Any, Dict, Optional, Type

import json
import hashlib
import json
import logging
from dataclasses import asdict, dataclass, field, fields
from pathlib import Path
from dataclasses import dataclass, field, fields, asdict
from typing import Any, Dict, List, Optional, Type

import numpy
import pandas


logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -50,7 +48,7 @@ def document_decoder(self, dictionary):
return dictionary


@dataclass(frozen=True)
@dataclass
class Document:
"""
Base data class containing some data to be queried.
Expand Down
17 changes: 5 additions & 12 deletions test/preview/dataclasses/test_document.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
from pathlib import Path
import dataclasses
import textwrap
import json
import textwrap
from pathlib import Path

import pytest
import pandas as pd
import numpy as np
import pandas as pd
import pytest

from haystack.preview import Document
from haystack.preview.dataclasses.document import DocumentEncoder, DocumentDecoder


@pytest.mark.unit
def test_document_is_immutable():
doc = Document(text="test text")
with pytest.raises(dataclasses.FrozenInstanceError):
doc.text = "won't work"
from haystack.preview.dataclasses.document import DocumentDecoder, DocumentEncoder


@pytest.mark.unit
Expand Down

0 comments on commit 282419d

Please sign in to comment.