-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ChatMessage store support (including reader+writer) #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10147173400Details
💛 - Coveralls |
vblagoje
force-pushed
the
chat_message_store
branch
from
July 29, 2024 14:13
8d82af6
to
762c938
Compare
vblagoje
changed the title
draft: Add ChatMessage store support (including reader+writer)
feat: Add ChatMessage store support (including reader+writer)
Jul 29, 2024
@vblagoje Could you please pick a different reviewer for this as I was involved in writing this? |
Ok deal @julian-risch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Enhances Haystack chat use cases by adding an in-memory store for chat messages along with components for message retrieval and writing.
What:
InMemoryChatMessageStore
to store chat messages in memory.ChatMessageStore
protocol to define a standard interface for chat message storage.ChatMessageRetriever
andChatMessageWriter
components for fetching and storing chat messages, respectively.How can it be used:
The following examples demonstrate how to use the newly added components:
Retrieving Chat Messages:
Writing Chat Messages:
Colab notebook (pipeline usage):
How did you test it:
InMemoryChatMessageStore
to ensure proper initialization, message storage behaviors, and serialization/deserialization functionality.ChatMessageRetriever
andChatMessageWriter
to validate interaction with the message store, including message retrieval and writing capabilities.Notes for the reviewer:
ChatMessageRetriever
of this initial version does not havefilters
andtop_k
run method parameters intentionally, as they will be added in subsequent PR.