Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for the new ChatMessage data class in ChatPromptBuilder #141

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Nov 25, 2024

Proposed Changes:

Since the newly-introduced ChatMessage dataclass in experimental defers in type signature, components in the core package that consume the above dataclass are no longer able to use the new version due to the type-checking constraints of the pipeline and breaking changes to the class.

This PR updates one such component to use the new version of the ChatMessage dataclass. Other components will be duly updated once tool support has been merged into the core package.

How did you test it?

Unit tests

Checklist

@shadeMe shadeMe requested a review from anakin87 November 25, 2024 14:34
@shadeMe shadeMe requested a review from a team as a code owner November 25, 2024 14:34
@shadeMe shadeMe requested review from Amnah199 and removed request for a team and Amnah199 November 25, 2024 14:34
@coveralls
Copy link

coveralls commented Nov 25, 2024

Pull Request Test Coverage Report for Build 12013770435

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 82.323%

Files with Coverage Reduction New Missed Lines %
components/tools/openapi/_schema_conversion.py 3 88.79%
Totals Coverage Status
Change from base Build 12010924988: 0.3%
Covered Lines: 2417
Relevant Lines: 2936

💛 - Coveralls

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I left two minor comments.

I see that "Sync docs with Readme" workflow is failing, but I don't know if it's related to the current PR.

@shadeMe
Copy link
Contributor Author

shadeMe commented Nov 25, 2024

I see that "Sync docs with Readme" workflow is failing, but I don't know if it's related to the current PR.

That's unrelated; has to do with the fact that this PR comes from a fork.

@anakin87 anakin87 self-requested a review November 25, 2024 15:59
@shadeMe shadeMe merged commit fe20b69 into deepset-ai:main Nov 25, 2024
9 of 10 checks passed
@shadeMe shadeMe deleted the feat/async-chat-prompt-builder branch November 25, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants