Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Async experiments #137

Merged
merged 28 commits into from
Nov 20, 2024
Merged

feat: Async experiments #137

merged 28 commits into from
Nov 20, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Nov 20, 2024

Related Issues

Proposed Changes:

Merge async-experiments feature branch into main.

How did you test it?

Full test suite

Notes for the reviewer

This is just a merge PR - its contents comprise of individual PRs that were reviewed previously. Just ensure that the tests pass.

Checklist

shadeMe and others added 26 commits September 6, 2024 11:50
* feat: Add support for async in `OpenSearchDocumentStore`

* Unused imports and formatting

* Fix logging and remove numpy dependency

* Update pyproject.toml

Co-authored-by: Silvano Cerza <[email protected]>

---------

Co-authored-by: Silvano Cerza <[email protected]>
* feat: Add support for async in `OpenSearchDocumentStore`

* Unused imports and formatting

* Fix logging and remove numpy dependency

* Update pyproject.toml

Co-authored-by: Silvano Cerza <[email protected]>

---------

Co-authored-by: Silvano Cerza <[email protected]>
@shadeMe shadeMe requested a review from silvanocerza November 20, 2024 11:28
@shadeMe shadeMe requested review from a team as code owners November 20, 2024 11:28
@shadeMe shadeMe removed the request for review from a team November 20, 2024 11:28
@shadeMe shadeMe requested review from dfokina and anakin87 and removed request for a team and anakin87 November 20, 2024 11:28
@coveralls
Copy link

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 11934321024

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-7.7%) to 81.899%

Files with Coverage Reduction New Missed Lines %
components/generators/chat/openai.py 22 88.48%
Totals Coverage Status
Change from base Build 11934301487: -7.7%
Covered Lines: 2303
Relevant Lines: 2812

💛 - Coveralls

@shadeMe
Copy link
Contributor Author

shadeMe commented Nov 20, 2024

Integration test failures are unrelated.

@shadeMe shadeMe merged commit aadc16d into main Nov 20, 2024
7 checks passed
@shadeMe shadeMe deleted the async-experiments branch November 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants