-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Async experiments #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perimental into async-experiments
* feat: Add support for async in `OpenSearchDocumentStore` * Unused imports and formatting * Fix logging and remove numpy dependency * Update pyproject.toml Co-authored-by: Silvano Cerza <[email protected]> --------- Co-authored-by: Silvano Cerza <[email protected]>
* feat: Add support for async in `OpenSearchDocumentStore` * Unused imports and formatting * Fix logging and remove numpy dependency * Update pyproject.toml Co-authored-by: Silvano Cerza <[email protected]> --------- Co-authored-by: Silvano Cerza <[email protected]>
…perimental into async-experiments
…perimental into async-experiments
…perimental into async-experiments
shadeMe
requested review from
dfokina and
anakin87
and removed request for
a team and
anakin87
November 20, 2024 11:28
Pull Request Test Coverage Report for Build 11934321024Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
shadeMe
force-pushed
the
async-experiments
branch
from
November 20, 2024 11:46
22fcc4b
to
22a5dfb
Compare
shadeMe
force-pushed
the
async-experiments
branch
from
November 20, 2024 11:50
22a5dfb
to
96c8167
Compare
Integration test failures are unrelated. |
silvanocerza
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Merge
async-experiments
feature branch intomain
.How did you test it?
Full test suite
Notes for the reviewer
This is just a merge PR - its contents comprise of individual PRs that were reviewed previously. Just ensure that the tests pass.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.