You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the above PR, the execution of the harness will break since it attempts to serialize the evaluation pipeline. To test it locally, either pull the above PR and build haystack-ai locally or remove the answer faithfulness metric from the harness.
I think the code is already there, and it shows how to use it. Nevertheless, this notebook needs some improvement regarding "documentation" and the code's organisation. Here are my comments:
Create an intro section shortly describing what the notebook is about
Do not assume anything is installed; explicitly state what dependencies are needed and the commands to install them. (I think you have most of it already there.)
Add textual descriptions/instructions to each section/snippet (i.e.: dataset prep., indexing, retrieval, eval., results analysis), instead of just the title
Make sure to have any relevant links to Documentation and/or blog posts related to the snippets/sections if needed
Move the imports to their related sections/snippets of code instead of having everything at the beginning
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Add a notebook to showcase the RAG evaluation harness.
Notes for the reviewer
Depends on the following: deepset-ai/haystack#7818
Without the above PR, the execution of the harness will break since it attempts to serialize the evaluation pipeline. To test it locally, either pull the above PR and build
haystack-ai
locally or remove the answer faithfulness metric from the harness.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.