feat: support for tools in OllamaChatGenerator
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
force-pushed
the
ollama-tools
branch
from
0c5f103 to
9ae65a0
Compare
Pull Request Test Coverage Report for Build 11144705556Details
💛 - Coveralls |
anakin87
commented
Sep 27, 2024
haystack_experimental/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
anakin87
commented
Sep 27, 2024
anakin87
requested review from
vblagoje and
shadeMe
and removed request for
a team
vblagoje
reviewed
Oct 1, 2024
haystack_experimental/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
haystack_experimental/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
vblagoje
approved these changes
Oct 2, 2024
haystack_experimental/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
haystack_experimental/components/generators/ollama/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
shadeMe
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
I'm adding support for tools in
OllamaChatGenerator. Similar to OpenAI PR #57.I'm trying to respect a balance between introducing new things and being compatible with existing code.
How did you test it?
CI, new tests.
Notes for the reviewer
I manually tested the Chat Generator using our notebook.
The implementation generally works well.
The simple use case and processing tool results with the Chat Generator are fully reproducible.
Reproducing the multi-tool chat application (with human in the loop) is not always stable with
llama3.2:3b/llama3.1:8b.The model tends to produce tool calls (even if not needed) and sometimes hallucinates tools.
Also, Ollama support for tools is not fully polished yet. (ollama/ollama#6127)
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.