Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsearch] fix: Filters not working with metadata that contain a space or capitalization #639

Merged
merged 3 commits into from
Apr 3, 2024
Merged

[Elasticsearch] fix: Filters not working with metadata that contain a space or capitalization #639

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c6b639
use dynamic template for mapping of additional fields
julian-risch Apr 3, 2024
b88127a
explicitly define mapping of content field
julian-risch Apr 3, 2024
1b0e392
remove redundant path_match
julian-risch Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...s/elasticsearch/src/haystack_integrations/document_stores/elasticsearch/document_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,20 @@ def __init__(
# configure mapping for the embedding field
mappings = {
"properties": {
"embedding": {"type": "dense_vector", "index": True, "similarity": embedding_similarity_function}
}
"embedding": {"type": "dense_vector", "index": True, "similarity": embedding_similarity_function},
"content": {"type": "text"},
},
"dynamic_templates": [
{
"strings": {
"path_match": "*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not sure you need this line, the template will run on any string field anyways

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. It's not needed and I removed it now. Thank you!

"match_mapping_type": "string",
"mapping": {
"type": "keyword",
},
}
}
],
}

# Create the index if it doesn't exist
Expand Down