Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Qdrant): allow payload indexing #552

Closed

Conversation

lambda-science
Copy link
Contributor

@lambda-science lambda-science commented Mar 6, 2024

This is still a draft:

  • I need to modify tests => Index two documents with two differents payload value. Check that user 1 can't access user 2 doc?
  • I need to remove the change to opensearch that I pushed too, woopsie

Related doc:

This MR aims to allow Qdrant user to create index on payload (metadata in Haystack naming) field.
This allow to filter way more efficiently vectors when searching.
And also it allows to restricti users to their own vectors only.

I'm open to comments, I'm not sure running it at each start-up of the collection is a good way to do it.
But From Qdrant discord:

andrey.vasnetsov —
overall, we recommed creating payload index before you upload data.
AFAIK, if you try to create same index twice, it won't trigger indexing

https://discord.com/channels/907569970500743200/1214958671742902272/1214958671742902272 (if you are on their discord)

@lambda-science lambda-science requested a review from a team as a code owner March 6, 2024 15:46
@lambda-science lambda-science requested review from julian-risch and removed request for a team March 6, 2024 15:46
@github-actions github-actions bot added integration:opensearch integration:qdrant type:documentation Improvements or additions to documentation labels Mar 6, 2024
@lambda-science lambda-science marked this pull request as draft March 6, 2024 15:49
@lambda-science
Copy link
Contributor Author

Woops, I pushed also my modification to Opensearch... heh, how to revert this

@lambda-science lambda-science deleted the feat/qdrant_payload_index branch March 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant