MongoDB Atlas: filters #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:mongodb-atlas
type:documentation
anakin87
commented
Mar 6, 2024
Comment on lines
-1
to
-4
| class MongoDBAtlasDocumentStoreError(Exception): | ||
| """Exception for issues that occur in a MongoDBAtlas document store""" | ||
|
|
||
| pass |
anakin87
commented
Mar 6, 2024
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| "MONGO_CONNECTION_STRING" not in os.environ, | ||
| reason="No MongoDB Atlas connection string provided", | ||
| ) | ||
| class TestDocumentStore(CountDocumentsTest, WriteDocumentsTest, DeleteDocumentsTest): | ||
| @pytest.mark.integration | ||
| class TestDocumentStore(DocumentStoreBaseTests): |
There was a problem hiding this comment.
I included all the base tests.
They also cover filters.
julian-risch
requested changes
Mar 7, 2024
integrations/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/filters.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #143