Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update INSTRUCTOR Embedders to work with new Document class #44

Merged
merged 3 commits into from
Nov 6, 2023
Merged

refactor: Update INSTRUCTOR Embedders to work with new Document class #44

merged 3 commits into from
Nov 6, 2023

Conversation

awinml
Copy link
Contributor

@awinml awinml commented Nov 2, 2023 •
edited
Loading

Proposed Changes

  • Updates the Document class usage in INSTRUCTOR Embedders:
    Document.text --> Document.content
    Document.metadata --> Document.meta

  • Adds a simple usage example in the class docstrings for InstructorDocumentEmbedder and InstructorTextEmbedder.

@awinml awinml requested a review from a team as a code owner November 2, 2023 11:12
@awinml awinml requested review from vblagoje and removed request for a team November 2, 2023 11:12
anakin87
anakin87 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

Thanks for this refactoring...

@anakin87 anakin87 merged commit a66add2 into deepset-ai:main Nov 6, 2023
1 check passed
This was referenced Nov 6, 2023
Closed
Merged
@awinml awinml mentioned this pull request Nov 7, 2023
Merged
@awinml awinml deleted the refactor_document_class branch November 29, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awinml @anakin87