Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Secret to Amazon Bedrock #416

Merged
merged 19 commits into from
Feb 16, 2024
Merged

Adopt Secret to Amazon Bedrock #416

merged 19 commits into from
Feb 16, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Feb 14, 2024 •
edited by masci
Loading

Part of #364

  • added Secret to __init__ AWS params
  • updated the tests
  • moved all the fixtures to a conftest.py
  • added an extra fixture to define env vars for testing
  • changed the pyproject.toml
    • to reflect test coverage over the code
    • added an ignore to allow for calling functions as params

@davidsbatista davidsbatista requested a review from a team as a code owner February 14, 2024 17:05
@davidsbatista davidsbatista requested review from vblagoje and removed request for a team February 14, 2024 17:05
@davidsbatista
Copy link
Contributor Author

nit: @shadeMe do you know about a more concise/clean way to define the AWS params on the __init__() with Secret?

anakin87
anakin87 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shadeMe
shadeMe suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of nitpicks.

...edrock/src/haystack_integrations/components/generators/amazon_bedrock/chat/chat_generator.py Show resolved Hide resolved
integrations/amazon_bedrock/tests/test_amazon_chat_bedrock.py Show resolved Hide resolved
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Feb 15, 2024
@davidsbatista davidsbatista merged commit d28ffa1 into main Feb 16, 2024
10 checks passed
@davidsbatista davidsbatista deleted the adopt-secret-amazon_chat branch February 16, 2024 11:00
@masci masci mentioned this pull request Feb 17, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@shadeMe shadeMe shadeMe approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
integration:amazon-bedrock type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @shadeMe @anakin87