Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update paths and titles #397

Merged
merged 4 commits into from
Feb 12, 2024
Merged

docs: update paths and titles #397

merged 4 commits into from
Feb 12, 2024

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Feb 12, 2024

Updated:

  • Correct order for the pydocs (to follow alphabetical order)
  • Paths to docstrings
  • Distinct names for Embedders

@dfokina dfokina requested a review from a team as a code owner February 12, 2024 15:54
@dfokina dfokina requested review from anakin87 and removed request for a team February 12, 2024 15:54
anakin87
anakin87 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

I approved this PR, but please consider my comments.

integrations/fastembed/pydoc/config.yml Outdated Show resolved Hide resolved
integrations/instructor_embedders/pydoc/config.yml Outdated Show resolved Hide resolved
integrations/instructor_embedders/pydoc/config.yml Outdated Show resolved Hide resolved
@dfokina dfokina merged commit 837edbb into main Feb 12, 2024
25 checks passed
@dfokina dfokina deleted the eval-docs branch February 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
integration:deepeval integration:fastembed integration:instructor-embedders integration:jina integration:uptrain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfokina @anakin87