Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows filters and persistent document stores for Chroma #342

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Allows filters and persistent document stores for Chroma #342

merged 4 commits into from
Feb 6, 2024

Conversation

nachollorca
Copy link
Contributor

Fixes #340 and #341

@nachollorca nachollorca requested a review from a team as a code owner February 5, 2024 13:03
@nachollorca nachollorca requested review from ZanSara and removed request for a team February 5, 2024 13:03
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

masci
masci approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, code LGTM I'm going to cut a release after I merge this.

@masci masci merged commit d412710 into deepset-ai:main Feb 6, 2024
9 checks passed
@anakin87 anakin87 mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@ZanSara ZanSara Awaiting requested review from ZanSara ZanSara is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
integration:chroma
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chroma: allow the use of persistent document stores
4 participants
@nachollorca @CLAassistant @masci @illorca-verbi