Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COHERE_API_KEY secret to CI environment #339

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

silvanocerza
Copy link
Contributor

Fixes #338.

Integration tests for Cohere integration are not running as of now, this fixes it.

The COHERE_API_KEY has already been added to the repo secrets.

@silvanocerza silvanocerza requested a review from a team as a code owner February 5, 2024 09:05
@silvanocerza silvanocerza requested review from masci and removed request for a team and masci February 5, 2024 09:05
@silvanocerza silvanocerza requested a review from sjrl February 5, 2024 09:07
@sjrl
Copy link
Contributor

sjrl commented Feb 5, 2024

This looks good! But I'm guessing this will causes tests to fail since it doesn't include the changes from #337. Should we push through anyways? Or we could merge your branch into mine.

@silvanocerza
Copy link
Contributor Author

@sjrl I'll rebase mine on top of your branch. 👍

@silvanocerza silvanocerza changed the base branch from main to cohere-tests February 5, 2024 09:11
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from cohere-tests to main February 5, 2024 09:14
@silvanocerza silvanocerza merged commit 40845c2 into main Feb 5, 2024
9 checks passed
@silvanocerza silvanocerza deleted the add-cohere-secret branch February 5, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Cohere integration tests requiring API key don't run
2 participants