-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstructured: fix metadata order mixed up #336
unstructured: fix metadata order mixed up #336
Conversation
…to feat/unstructured_meta_field
…/converters/unstructured/converter.py Co-authored-by: Stefano Fiorucci <[email protected]>
…/converters/unstructured/converter.py Co-authored-by: Stefano Fiorucci <[email protected]>
…/converters/unstructured/converter.py Co-authored-by: Stefano Fiorucci <[email protected]>
…rs. Raise error if glob and metadata list because unsafe
I'm sorry for the long commit list it's weird. It took all my previous history also from #242 Also: tests are failing because no hard drive space :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey... Thanks for the fix!
I generally agree with your approach.
Let's also update the docstrings about meta
to reflect the changes...
...tions/unstructured/src/haystack_integrations/components/converters/unstructured/converter.py
Outdated
Show resolved
Hide resolved
…/converters/unstructured/converter.py Co-authored-by: Stefano Fiorucci <[email protected]>
Sounds good to me ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fix #331
Because unstructured integration code use python
sets
, file orders are not preserved leading to metadata attribution to wrong filepaths. Using lists fix this as list are ordered.Also C/C from the issue, I added: