Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone - change dummy vector #301

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 31, 2024

Fixes #300.

I only changed the dummy vector from [0.0] * self.dimension to [-10.0] * self.dimension.

It is important to choose a highly improbable value for the user-supplied vectors, because this value is removed during retrieval.

@anakin87 anakin87 marked this pull request as ready for review January 31, 2024 08:59
@anakin87 anakin87 requested a review from a team as a code owner January 31, 2024 08:59
@anakin87 anakin87 requested review from masci and vblagoje and removed request for a team and masci January 31, 2024 08:59
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit 60038c0 into main Jan 31, 2024
4 checks passed
@anakin87 anakin87 deleted the pinecone-change-dummy-vector branch January 31, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinecone: Dense vectors must contain at least one non-zero value.
2 participants