-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cohere namespace change #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, one missing thing, we need an additional cohere
folder so that the import becomes:
from haystack_integrations.components.embedders.cohere import CohereDocumentEmbedder
This is needed because otherwise different integrations might mount generators with the same name under haystack_integrations.components.embedders
, overwriting each other
🤦 have another look @masci |
@vblagoje can you remove the |
O wow 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Why:
The changes in this pull request are focused on restructuring and reorganizing the codebase for better modularity and clarity. The modifications include updates to project configuration files, renaming of files and directories, and updating references to match the new structure. These adjustments enhance the maintainability of the code and align with a more standardized project layout.
What:
pyproject.toml
file to refer to new package locations and configuration settings.__init__.py
files to define public interfaces for embedders and generators components, ensuring clean imports and namespace management.embedders
andgenerators
modules to fall under a more descriptivehaystack_integrations
namespace.How can it be used:
pyproject.toml
updates can be used to accurately reflect dependencies and project configuration for building the wheel.__init__.py
files allow users to import classes likeCohereDocumentEmbedder
,CohereTextEmbedder
, andCohereGenerator
more intuitively using the updated paths.How did you test it:
test_cohere_chat_generator.py
andtest_document_embedder.py
Notes for the reviewer:
pyproject.toml
changes to ensure that all necessary configurations are appropriately updated and no essential configurations are omitted.