Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collection_name parameter and creation #215

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add collection_name parameter and creation #215

merged 2 commits into from
Jan 16, 2024

Conversation

silvanocerza
Copy link
Contributor

Depends on #214.

Now WeaviateDocumentStore can be initialized specifying a collection name, if that collection doesn't exist it will be created.

@silvanocerza silvanocerza self-assigned this Jan 16, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner January 16, 2024 10:56
@silvanocerza silvanocerza requested review from anakin87 and removed request for a team January 16, 2024 10:56
Base automatically changed from weaviate-mounting to main January 16, 2024 11:10
anakin87
anakin87 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@silvanocerza silvanocerza merged commit 020f273 into main Jan 16, 2024
18 checks passed
@silvanocerza silvanocerza deleted the collections-init branch January 16, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

@silvanocerza silvanocerza

Labels
integration:weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @anakin87